force message buffers to strings before decoding #283

Merged
merged 1 commit into from Feb 6, 2014

Conversation

Projects
None yet
2 participants
Contributor

bkw commented Feb 6, 2014

Although the top comment in anyjson suggests otherwise, not all json decoders can deal with kombu's message body buffers. This PR introduces a fix outlined at the bottom of http://kombu.readthedocs.org/en/latest/userguide/serialization.html

For reproducing the error, install libjson2 and watch the decoding errors, preferably by means of #281

SandyWalsh added a commit that referenced this pull request Feb 6, 2014

Merge pull request #283 from TelekomLabs/enforce_message_strings_for_…
…json

force message buffers to strings before decoding

@SandyWalsh SandyWalsh merged commit d63c28e into rackerlabs:master Feb 6, 2014

1 check passed

default The Travis CI build passed
Details
Contributor

bkw commented Feb 12, 2014

Seems there was something wrong with this pr, since #287 reverted it. I'm happy to help, but I don't know what problems this caused.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment