fix(neutron-understack): avoid loading config in the global module scope #1336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These options are all inside of ml2_understack and that should be where everything is loaded from. Drop the backwards support as its been deprecated long enough and there's no user of it.
Rather than patching the global scoped oslo_config, switch to using a fixture which resets between tests to ensure that things are cleaned up appropriately. This will be necessary when we no longer initialize oslo_config in the global/import scope of the module. While moving this it pointed out an issue with one of the tests missing a mock which attempted to hit the DB, which now couldn't be initialized because we didn't setup our configs because the data had the wrong types which is being fixed in this as well.
Upstream mechanisms don't initialize the config options in the global scope and this appears to cause issues in a 2025.2 world so follow how upstream behaves.
stevekeay
approved these changes
Oct 15, 2025
skrobul
approved these changes
Oct 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Dropped the old ml2_type_understack config options. Removed loading of the config options in the global module scope which seem to cause problems with 2025.2 versions of Neutron. The upstream ml2 drivers don't do it which is where I came to the conclusion. Updated the tests to use a fixture to allow overriding the config since its no longer global scope. This caused me to find an issue with one of the tests that needed to be resolved to make them pass again.