fix(nova-understack): fix up network prefix handling #1364
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The calculation of the target prefix from the client IP was incorrect based on the actual prefixes in use. This updates the code to have the correct client side prefixes and then updates the tests to match while including the correct target side prefixes as well.
Moved the storage prefix information to the configuration file instead of being hardcoded in the code.
nicholaskuechler
approved these changes
Oct 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The network prefix handling was hardcoded to incorrect prefix. The tests used IPs in the target range to find the target range so this updates the tests to use client range IPs for the validations. Updated to the actual ranges that are in use and moved that into the config file with the defaults being the in use values so that this can become configurable in the future.