feat(workflows): support inspection of fake-hardware devices #1407
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For devices using the fake hardware device type, skip over inspection and just set the resource-class to fakehw. Added additional robustness checks to other states to avoid failing on invalid conditions.
andrrax
reviewed
Nov 17, 2025
| - name: server-set-inspect-agent | ||
| # change the server to agent based inspection | ||
| depends: "inspect-server-redfish.Succeeded || inspect-server-redfish.Omitted" | ||
| depends: "server-start-state.Succeeded && (inspect-server-redfish.Succeeded || inspect-server-redfish.Omitted)" |
Contributor
There was a problem hiding this comment.
wouldn't this run if inspect-server-redfish (a just completed previous redfish inpsection) completed successfully? Is that really what is intended? I would expect an agent based inspection to only run if redfish/idrac-redfish isn't possible.
Contributor
Author
There was a problem hiding this comment.
You're right that's the end goal. But right now due to some hardware constraints and all the data we want not yet being in the redfish inspection data this is a compromise to get us to use redfish as much as possible.
nicholaskuechler
approved these changes
Nov 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For devices using the fake hardware device type, skip over inspection and just set the resource-class to fakehw. Added additional robustness checks to other states to avoid failing on invalid conditions.