feat: Adds ironic IPA image build tools #308
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaskuechler
force-pushed
the
build-ipa-image-20240916
branch
from
4b4b393 to
ca906a9
Compare
cardoe
requested changes
Sep 17, 2024
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
Definitely think we need to drop the hardcoded auth and use it dynamically if we need it.
nicholaskuechler
force-pushed
the
build-ipa-image-20240916
branch
3 times, most recently
from
976cbd9 to
c7cef30
Compare
skrobul
approved these changes
Sep 18, 2024
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
two minor suggestions, but otherwise lgtm
ironic-images/custom_elements/undercloud-ipa/install.d/50-PUC-427
Outdated
Show resolved
Hide resolved
nicholaskuechler
force-pushed
the
build-ipa-image-20240916
branch
3 times, most recently
from
859244e to
69ec1a1
Compare
nicholaskuechler
force-pushed
the
build-ipa-image-20240916
branch
from
69ec1a1 to
4054f8f
Compare
cardoe
approved these changes
Sep 19, 2024
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
So I'll merge this but I don't think we should be publishing a release on a PR. A build is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.