feat: utilize clouds.yaml for authentication in workflows #318
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll want to use clouds.yaml for authentication across the board in the future so make this available to these workflows.
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified FilesNo covered modified files...
|
skrobul
approved these changes
Sep 18, 2024
cardoe
force-pushed
the
workflow-auth
branch
2 times, most recently
from
752a17f to
902b0d0
Compare
Provided a wrapper so that we can use clouds.yaml for authentication from all of our workflows. Dropped the API version override from Ironic as it conflicted with how negotiation works. Negiotation sets a minimum and a maximum range based on server and client support. 1.82 is older than the client and the server support so it failed. Previous negotiation when done through the manually configured client resulted in a range of 1.1 to 1.90, which is why we needed to pass 1.82 to get new enough micro API. But this client results in 1.88 being used.
Remove the old authentication and utilize clouds.yaml exclusively.
These aren't necessary anymore so remove them.
cardoe
force-pushed
the
workflow-auth
branch
from
902b0d0 to
f7c6477
Compare
nicholaskuechler
approved these changes
Sep 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Utilize clouds.yaml for our workflows to authenticate against OpenStack for running operations. This credential is kept up to date by External Secrets.