feat: Add building ubuntu image #389
Conversation
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
This should just be generically called "ubuntu-$release" or some such. Definitely no keekz in the name and extras was there just cause that's the package pulled in.
| - name: Set timestamp environment variable | ||
| run: echo "TIMESTAMP=$(git show --no-patch --no-notes --pretty='%cd' --date=format:'%Y%m%d%H%M%S' ${{ env.COMMIT_HASH }})" >> $GITHUB_ENV | ||
|
|
||
| - name: Publish Release |
There was a problem hiding this comment.
Now that we're doing a matrix I think we'll have to split up the release into its own step. Because this will cause two release tags to be published. So I think each build will need to use the https://github.com/actions/upload-artifact to upload the built bits. Then the create release step will need to download those artifacts and make the release from that so that there's one release with all the files.
There was a problem hiding this comment.
I used timestamp of the commit sha so that it would be one release. The previous version generated a timestamp when the job run so with two jobs, you get two timestamp and 2 releases. The image that I added to the PR shows the one release and the three built files.
There was a problem hiding this comment.
So the GitHub Actions matrix runner will run each one separately to completion. You are creating the release in the matrix so it'll make 2 releases on each run instead of one combined release.
There was a problem hiding this comment.
https://github.com/argoproj/argo-workflows/blob/main/.github/workflows/release.yaml that's an example of a matrix then coming back together to one release.
transt
force-pushed
the
PUC-535
branch
2 times, most recently
from
9732597 to
0e15603
Compare
chore(deps): update helm release argo-cd to v7.6.12
2 participants
Add the directory keekz-ubuntu-extras under ironic-images.
Update .github/workflows/build-ironic-images.yaml to build ubuntu image.
Test run on a fork repo:
