feat: adds github workflow to create an ironic esp image #450
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicholaskuechler
force-pushed
the
PUC-652-20241107-1
branch
from
ddd33ea to
b5addf0
Compare
cardoe
requested changes
Nov 7, 2024
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
Add this to the regular images workflow so it's all released together.
nicholaskuechler
force-pushed
the
PUC-652-20241107-1
branch
20 times, most recently
from
4673d5e to
8752040
Compare
nicholaskuechler
force-pushed
the
PUC-652-20241107-1
branch
from
8752040 to
cb3b379
Compare
cardoe
reviewed
Nov 8, 2024
cardoe
approved these changes
Nov 8, 2024
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
So this proves what I was saying on the original change here that the release needs to be in a final step as one upload.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://docs.openstack.org/ironic/latest/install/configure-esp.html
https://docs.openstack.org/ironic/latest/install/configure-pxe.html#uefi-pxe-grub