feat: PUC-765: use segmentation_id generated by neutron as ucvni_id in nautobot #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebsyed12
changed the title
stevekeay
reviewed
Mar 25, 2025
| ucvni_group: str, | ||
| network_name: str, | ||
| segment_id: int | None = None, | ||
| segment_id: int, |
Contributor
There was a problem hiding this comment.
Consistency is king - please can we call this segmentation_id to match openstack, or ucvni_id to match nautobot?
haseebsyed12
force-pushed
the
PUC-765-neutron-segment-id
branch
2 times, most recently
from
b79e125 to
fa85fb8
Compare
haseebsyed12
force-pushed
the
PUC-765-neutron-segment-id
branch
from
fa85fb8 to
d03ce63
Compare
cardoe
approved these changes
Mar 26, 2025
stevekeay
approved these changes
Mar 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for code clean up related to VLAN type networks is, we were experimenting with VLAN type networks but we switched back to VXLAN networks and in future also we want to use VXLAN type networks only.