Skip to content

fix: change bios settings for enroll, and add more LLDP details on missing neighbors #807

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 27, 2025
Merged

fix: change bios settings for enroll, and add more LLDP details on missing neighbors #807

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2768524
Show more detail about LLDP neighbors when we don't have enough
stevekeay Mar 27, 2025
db0e33f
Don't set HTTP device (PXE) interface
stevekeay Mar 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion python/understack-workflows/understack_workflows/bmc_bios.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ def required_bios_settings(pxe_interface: str) -> dict:
return {
"PxeDev1EnDis": "Enabled",
"PxeDev1Interface": pxe_interface,
"HttpDev1Interface": pxe_interface,
"TimeZone": "UTC",
}

Expand Down
8 changes: 6 additions & 2 deletions python/understack-workflows/understack_workflows/discover.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,11 +29,15 @@ def discover_chassis_info(bmc: Bmc) -> ChassisInfo:

attempts_remaining = LLDP_DISCOVERY_ATTEMPTS
while len(device_info.neighbors) < MIN_REQUIRED_NEIGHBOR_COUNT:
lldp_table = {
i.name: f"{i.remote_switch_mac_address}/{i.remote_switch_port_name}"
for i in device_info.interfaces
}
logger.info(
"%s does not have enough LLDP neighbors (saw %d), need at least %d. ",
"%s does not have enough LLDP neighbors, need %d or more, got %s",
bmc,
len(device_info.neighbors),
MIN_REQUIRED_NEIGHBOR_COUNT,
lldp_table,
)
if not attempts_remaining:
raise Exception(
Expand Down