-
Notifications
You must be signed in to change notification settings - Fork 7
feat: deploy-cli for scaffolding #839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
cardoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall I think it covers what we've got and really shows the gaps of how we want to improve. Looking at this and the diff tool makes me think about some k8s integration for that and bringing it to this as another sub command.
|
Maybe a "goal" flow of this is... # install understack
understack deploy init $DEPLOY_NAME # where it makes `pwd/$DEPLOY_NAME` and populates a directory structure?A lot of those environment variables are a one time thing or not even needed if you're using a separate ArgoCD without baking it into your combined cluster. |
skrobul
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what do you think about removing the dependency on the kubeseal binary and using the package directly?
I honestly don't even want to have kubeseal a requirement but some step that prior to committing your secrets you do something with them. |
That is what I was thinking as well, I have to check how it's working as it's having lots of parameter. |
cardoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These were still there from my prior review.
I cannot see the help without having |
So I see the name is still the same. Not that Further I think requiring the env vars all the time (and the understack deploy [--deploy-path $UC_DEPLOY] init $DEPLOY_NAMEWhere ---
name: $DEPLOY_NAMEThen we can have further operations to set |
This is an initial implementation of a tool to help create and manage the life cycle of the deployment repository and the various deployment environments. The documentation will be updated in the future to utilize this tool.
|
So biggest review comment would be to have a more descriptive commit messages in the end. |
cardoe
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll iterate further in tree.
This is moved from
https://github.com/RSS-Engineering/undercloud-deploy-cli
All the steps on how to run are README as well.
How to run
go run *.go allgo run *.go help