feat: etcd backup #848
Merged
feat: etcd backup #848
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
reviewed
Apr 17, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
So rather than have to skip the templates what if we have them have a .yaml.tpl extension?
I also think this shouldn't be in the components appset. This is probably an infra item.
This removes option to customise the etcd endpoint used for backups. We always want to backup just the local host so it was not really needed.
skrobul
force-pushed
the
package-etcd-job
branch
from
b5ff76c to
3c67415
Compare
Collaborator
Author
Didn't know that trick, that's certainly better - thank you!
Moved and adapted to the new syntax |
cardoe
approved these changes
Apr 30, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
This works. Remind me to show you component patches. For small templates it might be easier?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds daily backups of etcd