Skip to content

fix(argocd): revert finalizer on appproject #851

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 17, 2025
Merged

fix(argocd): revert finalizer on appproject #851

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions apps/appsets/project-understack-infra.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ apiVersion: argoproj.io/v1alpha1
kind: AppProject
metadata:
name: understack-infra
# Finalizer that ensures that project is not deleted until it is not referenced by any application
finalizers:
- resources-finalizer.argocd.argoproj.io
# we do not want the finalizer here as it deletes all resources as
# they move between AppProject's
spec:
sourceRepos:
- '*'
Expand Down
5 changes: 2 additions & 3 deletions apps/appsets/project-understack-operators.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ apiVersion: argoproj.io/v1alpha1
kind: AppProject
metadata:
name: understack-operators
# Finalizer that ensures that project is not deleted until it is not referenced by any application
finalizers:
- resources-finalizer.argocd.argoproj.io
# we do not want the finalizer here as it deletes all resources as
# they move between AppProject's
spec:
sourceRepos:
- '*'
Expand Down
5 changes: 2 additions & 3 deletions apps/appsets/project-understack.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,8 @@ apiVersion: argoproj.io/v1alpha1
kind: AppProject
metadata:
name: understack
# Finalizer that ensures that project is not deleted until it is not referenced by any application
finalizers:
- resources-finalizer.argocd.argoproj.io
# we do not want the finalizer here as it deletes all resources as
# they move between AppProject's
spec:
sourceRepos:
- '*'
Expand Down