feat: physical_network lookup using ironic client #863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mfencik
force-pushed
the
PUC-886
branch
13 times, most recently
from
12ae3be to
bc20e28
Compare
mfencik
changed the title
cardoe
reviewed
Apr 25, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
So my initial comments are that we need to make sure to do this only for bare metal ports for bare metal devices. We're going to have other port types like neutron router ports and the such and that will need to be ignored.
Contributor
Author
This is now adjusted and it will be refactored when work in https://rackspace.atlassian.net/browse/PUC-904 is done |
cardoe
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we're determining physical network name from local link info that is available in binding profile. This however is not great as we should be looking into the baremetal port physical_network field.
This PR is fixing that.