chore(neutron): replace manual API calls with pynautobot #872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cardoe
commented
Apr 28, 2025
Use the pynautobot API calls instead of making manual API calls in the neutron mechanism. While typing is a bit awkward and needs some casts currently, it will be better for long term maintainability to use the API library than writing our own calls everywhere. This can be seen by the ability to consistently catch errors and return them back to neutron which should eliminate a few 500 errors that users see without any context.
Contributor
Author
|
A bunch of the |
haseebsyed12
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the pynautobot API calls instead of making manual API calls in the neutron mechanism. While typing is a bit awkward and needs some casts currently, it will be better for long term maintainability to use the API library than writing our own calls everywhere. This can be seen by the ability to consistently catch errors and return them back to neutron which should eliminate a few 500 errors that users see without any context.