feat(cli): provide consistent way to define path to deployment repo #886
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
So I handled the lint error and adjusted when the help text is produced to better report to the user what is happening. |
skrobul
approved these changes
Apr 30, 2025
abhimanyu003
approved these changes
Apr 30, 2025
abhimanyu003
requested changes
Apr 30, 2025
If you ran the binary with no arguments then nothing happened and there was no details on what to do. The binary also didn't include its own name so the help output was awkward so add the name of the binary.
To help all the deployment commands operate on the correct path, add a global/persistent flag that defines the path to your deployment repo and changes to its path for all the execution of the commands.
The value used here was the path to the deploy repo instead of the deployment name.
abhimanyu003
approved these changes
Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide a consistent way to define the path to your deployment repo so that all commands can behave the same way.