feat: run inspection on enroll #973
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haseebsyed12
changed the title
haseebsyed12
force-pushed
the
puc-314-set-pxe-interface
branch
from
0df7fd1 to
7c3490c
Compare
…g update_pxe_enabled flag to enable/disable port updation while inspect
haseebsyed12
force-pushed
the
puc-314-set-pxe-interface
branch
from
7c3490c to
c3500de
Compare
cardoe
previously requested changes
Jun 10, 2025
Contributor
cardoe
left a comment
cardoe
left a comment
There was a problem hiding this comment.
You can change the container references for testing but you need to revert that before merging. The PR will go away once it is merged.
haseebsyed12
changed the title
Collaborator
skrobul
changed the title
skrobul
approved these changes
Jun 11, 2025
Collaborator
skrobul
left a comment
skrobul
left a comment
There was a problem hiding this comment.
+1
Changed the PR title to reflect that we run inspection on enroll (we don't call redfish inspection specifically, just whatever is configured at the time)
skrobul
dismissed
cardoe’s stale review
ephemeral container image references have been removed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this fix also contains patch https://review.opendev.org/c/openstack/ironic/+/951716 for using update_pxe_enabled flag to enable/disable port updation while inspect. In our case we disable it which is done in https://github.com/RSS-Engineering/undercloud-deploy/pull/350