Skip to content

Conversation

@skrobul
Copy link
Collaborator

@skrobul skrobul commented Jun 11, 2025

This should stop us from accidentally merging code with reference to the ephermeral container images.

Example failure: https://github.com/rackerlabs/understack/actions/runs/15578200340

@skrobul skrobul marked this pull request as draft June 11, 2025 06:47
@skrobul skrobul force-pushed the no-pr-images-in-main branch 4 times, most recently from 874eb45 to 4fc55ee Compare June 11, 2025 07:00
@skrobul skrobul marked this pull request as ready for review June 11, 2025 07:28
@skrobul skrobul requested a review from a team June 11, 2025 07:28
@skrobul skrobul force-pushed the no-pr-images-in-main branch from aed4085 to 4f4e43e Compare June 11, 2025 08:55
Copy link
Contributor

@stevekeay stevekeay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice idea.

skrobul added 2 commits June 11, 2025 18:41
This should stop us from accidentally merging code with reference to the
ephermeral container images.
@skrobul skrobul force-pushed the no-pr-images-in-main branch from 4f4e43e to 0400035 Compare June 11, 2025 17:41
@skrobul skrobul added this pull request to the merge queue Jun 11, 2025
Merged via the queue into main with commit 6923d22 Jun 11, 2025
17 checks passed
@skrobul skrobul deleted the no-pr-images-in-main branch June 11, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants