Copy source location to generate runtime paths. #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexi-lambda
reviewed
Feb 6, 2018
| @@ -186,7 +186,8 @@ | |||
| (path-of | |||
| #,(datum->syntax | |||
| #'orig-stx | |||
There was a problem hiding this comment.
I guess it doesn’t really matter in this case, since this-expression-source-file is a macro and the lexical context on the surrounding syntax object is irrelevant, but it seems slightly suspect to adjust the lexical context here at all. It’d work fine to just use #'here for the lexical context and #'orig-stx for the source location information.
|
I have tested and can confirm this removes many of the references to build-time rpaths in compiled files. Thanks so much! |
|
@mflatt Is this ok to merge? |
|
LGTM |
Fix found by @lexi-lambda. Bug reported by dbenoit@fedoraproject.org.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix found by @lexi-lambda. Bug reported by dbenoit@fedoraproject.org.