Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Already on GitHub? Sign in to your account

Added https over http proxy support #272

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
3 participants

Currently, the planet2 will access server by https, but net/url cannot support https proxy.
Adding this patch will help to use planet2 by http proxy.

Owner

samth commented Mar 31, 2014

@jeapostrophe Can you look into this? I think this was brought up on the mailing list recently as well.

Collaborator

jeapostrophe commented Apr 16, 2014

I finally got a chance to look at this. Because of the new http-client library, the patch isn't really useful any more because a lot would need to change. However, I'll put it on my TODO list to implement it using this as a model.

Owner

samth commented Apr 30, 2014

@jeapostrophe Does this mean this PR should be closed?

Collaborator

jeapostrophe commented May 1, 2014

I won't merge this, but I will comment on it when I adapt the patch. I don't want closing it to imply to the original author that we're "done" with it, but in principle I think it could be closed.

Owner

samth commented May 1, 2014

I think just closing pull requests that we aren't going to merge is fine.

Collaborator

jeapostrophe commented May 1, 2014

K

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment