Fixed uses of free-identifier=? guards in errortrace #549

Closed
wants to merge 1 commit into
from

Conversation

Projects
None yet
4 participants
Contributor

wilbowma commented Jan 16, 2014

free-identifier=? expects, contrary to documentation, a syntax?, causing
contract errors. (and (identifier? ...) ...) solves this.

Fixed uses of free-identifier=? guards
free-identifier=? expects, contrary to documentation, a syntax?, causing
contract errors. (and (identifier? ...) ...) solves this.
Owner

samth commented Feb 25, 2014

@mflatt @stamourv Can you take a look at this patch?

Contributor

stamourv commented Mar 31, 2014

Looks reasonable.
@bluephoenix47: can you add a test that would have failed with the old version?

Owner

mflatt commented May 1, 2014

I'm having trouble seeing how a failure can happen. The function should be called only on fully expanded forms, and I think those are either identifiers or sequences that start with an identifier. It's probably better to add the guard anyway, though, so I'll merge the patch.

Contributor

wilbowma commented May 2, 2014

@stamourv, sorry this is still a little ways down on my TODO list.

@mflatt, I discovered this when trying to use errortrace to do some
profiling, and got several contract error messages that seemed to be
caused exactly by free-identifier=? being called on syntax? that were
not identifier? If this shouldn't happen, then perhaps this patch is just
duck tape over another problem.

Owner

samth commented May 6, 2014

Merged.

@samth samth closed this May 6, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment