Adds a #:shelf-life argument to valid-id-cookie?
#25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and `request-id-cookie`. The current `#:timeout` argument does something counterintuitive: it requires that the cookie have been created *before* a certain moment in time, effectively specifying a *minimum* age. The new `#:shelf-life` argument supports specifying a maximum age.
Contributor
|
Thanks! |
Member
|
This seems to have a broken test: http://drdr.racket-lang.org/40128/racket/share/pkgs/web-server-test/tests/web-server/http/cookies-test.rkt |
Contributor
Author
|
Thanks — I pushed #26 to fix the test. (I'd overlooked that the test cases were using a cookie from a fixed time well over 500 seconds in the past.) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
#:shelf-lifeargument tovalid-id-cookie?andrequest-id-cookie.The current
#:timeoutargument does something counterintuitive:it requires that the cookie have been created before a certain
moment in time, effectively specifying a minimum age.
The new
#:shelf-lifeargument supports specifying a maximum age.