New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public info #14

Merged
merged 13 commits into from May 13, 2014

Conversation

Projects
None yet
5 participants
@RSTJNII
Contributor

RSTJNII commented May 6, 2014

Merge Thomas C's public_info Ohai plugin into rackops_rolebook

@RSTJNII

This comment has been minimized.

Contributor

RSTJNII commented May 6, 2014

Question to the floor: Where do we want to have our "default" attribute location be for the external IP? Currently it is in public_info.remote_ip, is this sufficient or should we save it in another location as well?

@doublerr

This comment has been minimized.

Contributor

doublerr commented May 6, 2014

@RSTJNII public.info.external_ip?

Also just a reminder about tags. As Discussed, we can set a tag as "external_ip: 1.1.1.1" as an example

@RSTJNII

This comment has been minimized.

Contributor

RSTJNII commented May 12, 2014

public_info.remote_ip is already being consumed in customer environments and so I think it should be retained. I don't think having a second attribute, public_info.external_ip, in the same subhash adds value. I opted to leave naming alone, and made the tag RemoteIP to keep things consistent.

Tagging is working. Note that the tag is just a string, not a key:value pair.

$ knife tag list web-stg-dfw-01
RemoteIP:50.56.152.222
@prometheanfire

This comment has been minimized.

Contributor

prometheanfire commented May 12, 2014

Should be good, but can we get a test?

@RSTJNII

This comment has been minimized.

Contributor

RSTJNII commented May 12, 2014

This is failing tests. Will resubmit once testing is resolved.

@RSTJNII RSTJNII closed this May 12, 2014

@RSTJNII

This comment has been minimized.

Contributor

RSTJNII commented May 12, 2014

Cookbook doesn't appear to be in Jenkins, passes on my box:

rackops_rolebook $ bundle exec rake; echo $?
<Snip run>
-----> Destroying <default-debian-720>...
       [default] Forcing shutdown of VM...
       [default] Destroying VM and associated drives...
       Vagrant instance <default-debian-720> destroyed.
       Finished destroying <default-debian-720> (0m8.10s).
0

I added an exception into the recipe if this doesn't run properly as I believe an explicit convergence failure is better than bad data or a failure somewhere where the data is consumed. This also serves as a simple test as if any of the moving parts aren't moving node['public_info'] won't be set leading to a convergence failure during kitchen tests.

Rubocop revision was also dropped to a known working revision as RuboCop 0.21 and 0.20 were throwing dependency errors on my box.

@RSTJNII RSTJNII reopened this May 12, 2014

@martinb3

This comment has been minimized.

Contributor

martinb3 commented May 13, 2014

👍 from me.

@RSTJNII

This comment has been minimized.

Contributor

RSTJNII commented May 13, 2014

Test still passing after master merge:

rackops_rolebook $ bundle exec rake
<Snip Run>
-----> Destroying <default-debian-720>...
       [default] Forcing shutdown of VM...
       [default] Destroying VM and associated drives...
       Vagrant instance <default-debian-720> destroyed.
       Finished destroying <default-debian-720> (0m6.03s).
rackops_rolebook $ echo $?
0

schplat added a commit that referenced this pull request May 13, 2014

@schplat schplat merged commit 0ce0550 into master May 13, 2014

@schplat schplat deleted the public_info branch May 13, 2014

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment