Rename request_tests.go to request_test.go #614

Merged
merged 1 commit into from Oct 13, 2016

Projects

None yet

5 participants

@MatMaul
Contributor
MatMaul commented Sep 20, 2016

This is the usual convention and it is assumed by several tools like godep.

Needed for trust support in Kubernetes :
kubernetes/kubernetes#32111

@codevulture
Contributor

+1 godeps failure reason!

@MatMaul
Contributor
MatMaul commented Sep 20, 2016

Seems like the added tests were not call at all, because one is failing :) Next update should fix it.

@coveralls
coveralls commented Sep 20, 2016 edited

Coverage Status

Coverage decreased (-0.1%) to 80.484% when pulling eb0ce6d on MatMaul:rename_test_file into c90cb95 on rackspace:master.

@strigazi

@jrperritt Can you have a look at this?

@MatMaul
Contributor
MatMaul commented Sep 26, 2016

@jrperritt can we merge this please ? we are waiting for it to add trust id to Kubernetes. Thanks !

@strigazi
strigazi commented Oct 5, 2016

@jrperritt Do you have an update? We are blocked in kubernetes side.

@@ -87,12 +66,3 @@ func TestTrustIDTokenID(t *testing.T) {
`)
}
-
-func TestFailurePassword(t *testing.T) {
@jrperritt
jrperritt Oct 11, 2016 Contributor

Don't delete tests; fix them instead.

@MatMaul
MatMaul Oct 11, 2016 Contributor

This one never worked (those tests actually never ran before because of the filename), and doesn't seem really useful. I fixed the other one which was failing too. Be my guest if you understand and know how to fix this one.

@jrperritt
jrperritt Oct 11, 2016 Contributor

Let me try again: If you want this PR merged, fix the unit test.

@MatMaul MatMaul Rename request_tests.go to request_test.go
This is the usual convention and it is assumed by several tools like godep.
6091674
@coveralls
coveralls commented Oct 13, 2016 edited

Coverage Status

Coverage decreased (-0.1%) to 80.494% when pulling 6091674 on MatMaul:rename_test_file into c90cb95 on rackspace:master.

@jrperritt jrperritt merged commit e00690e into rackspace:master Oct 13, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@MatMaul MatMaul deleted the MatMaul:rename_test_file branch Oct 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment