Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow port update() to modify security groups. #602

Merged

Conversation

kaecyra
Copy link
Contributor

@kaecyra kaecyra commented May 19, 2015

Allows the \OpenCloud\Networking\Resource\Port::update() method to affect security groups, as per API and library documentation. Currently the 'securityGroups' option is silently ignored.

Additional keys are also omitted in the $updateKeys property, but they are beyond the scope of this pull-request:

adminStateUp
fixedIps
deviceOwner

@jamiehannaford
Copy link
Contributor

👍 LGTM

jamiehannaford pushed a commit that referenced this pull request May 20, 2015
Allow port update() to modify security groups.
@jamiehannaford jamiehannaford merged commit abe8163 into rackspace:working May 20, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants