Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed animation example, use this.context #891

Closed
wants to merge 1 commit into from
Closed

fixed animation example, use this.context #891

wants to merge 1 commit into from

Conversation

brigand
Copy link
Contributor

@brigand brigand commented Feb 27, 2015

This uses the new this.context.router, and specifically uses .getCurrentPath() which is 95% of the time what uniquely identifies the page.

Questions:

  • should it be using contextTypes, or the mixin?
  • should it directly require react-router/modules/PropTypes to get PropTypes.router, or use .any?

I'm not sure what addHandlerKey does, but it works without it, and we're setting a key ourselves anyway.

@gaearon
Copy link
Contributor

gaearon commented Feb 28, 2015

addHandlerKey is something from distant path so it should be safe to remove.

@ryanflorence
Copy link
Member

cherry-picked as 14daf27 thanks

@lock lock bot locked as resolved and limited conversation to collaborators Jan 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants