Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Animate no longer supports objects #3017

Open
Inversion-des opened this issue Jun 26, 2017 · 3 comments
Open

Animate no longer supports objects #3017

Inversion-des opened this issue Jun 26, 2017 · 3 comments

Comments

@Inversion-des
Copy link

Description:

If I try to use map — there is an error:

Uncaught Error: ractive.animate(...) no longer supports objects. Instead of ractive.animate({
  'counter': 20
}, {...}), do
ractive.animate('counter', 20, {...});

But in docs there is a sample with a map

Versions affected:

at least 0.8.14, 1.0.0

Platforms affected:

Chrome on Win

Code:

r.animate({counter: 20}, { duration: 2000 });

@fskreuz
Copy link
Contributor

fskreuz commented Jun 26, 2017

Marking as pending since I'm not a user of animate so I can't tell from the top of my head if it's a docs bug or a code bug. Will either need digging or someone who has intimate knowledge on ractive.animate(). 🙂

@fskreuz
Copy link
Contributor

fskreuz commented Jun 26, 2017

If it can help, related commit and PR:

@fskreuz
Copy link
Contributor

fskreuz commented Jun 26, 2017

After a bit of digging, I found that animate no longer supported a map argument for a while. #2155. Marking this issue for deprecation cleanups, and will update docs.

Thanks for the report. 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants