Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dependency on simple_form ~> 3.0.1 - 3.1.0 needed #637

Closed
tomg65 opened this issue Feb 11, 2015 · 4 comments
Closed

dependency on simple_form ~> 3.0.1 - 3.1.0 needed #637

tomg65 opened this issue Feb 11, 2015 · 4 comments

Comments

@tomg65
Copy link
Contributor

tomg65 commented Feb 11, 2015

Hi,

I tried to integrate forem in an existing rails apllication (rails 4.1.9 ruby 2.1.3)
There is already a cms engine (https://github.com/AlchemyCMS/alchemy_cms) integrated that depends on simple_form 3.1.0.

So I can't install forem in this application.

Is it possible to upgrade the dependency in forem?

Thanks
Thomas

@radar
Copy link
Collaborator

radar commented Feb 12, 2015

I don't understand. Why can't you install Forem into this application?

@radar
Copy link
Collaborator

radar commented Feb 12, 2015

If all it is is the simple_form dependency in the gemspec, why not submit a patch to change it to something more like:

s.add_dependency 'simple_form', '~> 3.0'

I think that would seem pretty reasonable.

@tomg65
Copy link
Contributor Author

tomg65 commented Feb 12, 2015

bundler stops while showing a conflict message in combination with the other gem, which is dependent on simple_form 3.1
OK - changed the dependency in your gemspec. and made a pull request #639
With this adaption bundle install works.

@radar
Copy link
Collaborator

radar commented Jul 13, 2015

Done already I believe.

@radar radar closed this as completed Jul 13, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants