New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

`agft` is broken #9962

Closed
XVilka opened this Issue Apr 26, 2018 · 8 comments

Comments

Projects
None yet
4 participants
@XVilka
Collaborator

XVilka commented Apr 26, 2018

Check on any single function.

@cyanpencil see this please too.

@cyanpencil

This comment has been minimized.

Collaborator

cyanpencil commented Apr 26, 2018

@XVilka, are you referring to the fact that it only prints the tiny graph for the function in the current seek, and not the function provided in the argument?
(example: agft and agft sym.xxx are the same because the argument is ignored)

@XVilka

This comment has been minimized.

Collaborator

XVilka commented Apr 27, 2018

See it on some of the functions of /bin/ls:
img

@cyanpencil

This comment has been minimized.

Collaborator

cyanpencil commented May 1, 2018

Since I wasn't able to find the source of this bug I manually binary-serched on the commit history to see when it was introduced.

I found out that tiny graph edges were broken since the very commit that introduced them.
In particular, in commit b49314a94 we can see they were introduced because in line 3052 in file graph.c the following if was commented out:

// TODO: add an option/key to toggle this
if (!g->is_tiny) {
		agraph_print_edges (g);
}

Before that commit, the tiny graph was rendered without edges, like this:
2018-05-01-004143_652x275_scrot

And this is the same function just after that commit:
2018-05-01-004534_655x380_scrot

So this makes me think that tiny graph edges were never meant to be in the first place...
Please @radare correct me if I'm wrong

@radare

This comment has been minimized.

Owner

radare commented May 1, 2018

@cyanpencil

This comment has been minimized.

Collaborator

cyanpencil commented May 1, 2018

Thank you for your answer @radare , but I think I didn't formulate well the question.

The problem is that graph.edges = 2 by default, so that we the agft command is ran, the broken edges of the tiny graph are shown by default.

My question is then: should the graph edges be disabled when running agft (and, more in general, when displaying the tiny graph) unless specified by the user?

@radare radare referenced this issue May 2, 2018

Merged

Fix graph modes #10000

@radare

This comment has been minimized.

Owner

radare commented May 2, 2018

i think the tinygraph looks better without edges because those add a lot of noise to the representation, but they are sometimes useful (or beauty if you need a new wallpaper). so yep i agree on changing the behaviour

@ret2libc

This comment has been minimized.

Collaborator

ret2libc commented May 3, 2018

I agree that tiny graph mode was never meant to be a real thing IMHO. Not sure what's their purpose...

@radare

This comment has been minimized.

Owner

radare commented May 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment