New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

r2con: ESIL: fix arm64 emulation for str pre/post index #11447

Merged
merged 2 commits into from Sep 8, 2018

Conversation

Projects
None yet
3 participants
@anisse
Contributor

anisse commented Sep 8, 2018

While writing an r2wars bot at r2con, I found these missing emulated str pre/postindex.

This is only mildly tested, but should work.

anisse added some commits Sep 8, 2018

esil: improve arm64 simple store pre/post index emulation for r2wars
While writing an r2wars bot, I found that there was a missing emulation
of pre/post index of arm64. It's supported for ldp/stp, but not
single-register stores.

@anisse anisse changed the title from ESIL: fix arm64 emulation for str pre/post index to r2con: ESIL: fix arm64 emulation for str pre/post index Sep 8, 2018

@codecov-io

This comment has been minimized.

Show comment
Hide comment
@codecov-io

codecov-io Sep 8, 2018

Codecov Report

Merging #11447 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11447      +/-   ##
==========================================
- Coverage   34.47%   34.47%   -0.01%     
==========================================
  Files         891      891              
  Lines      277552   277565      +13     
==========================================
+ Hits        95688    95691       +3     
- Misses     181864   181874      +10
Impacted Files Coverage Δ
libr/anal/p/anal_arm_cs.c 73.13% <40%> (-0.32%) ⬇️
libr/bin/pdb/pdb_downloader.c 76.42% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0baadb4...e09b5dd. Read the comment docs.

codecov-io commented Sep 8, 2018

Codecov Report

Merging #11447 into master will decrease coverage by <.01%.
The diff coverage is 40%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #11447      +/-   ##
==========================================
- Coverage   34.47%   34.47%   -0.01%     
==========================================
  Files         891      891              
  Lines      277552   277565      +13     
==========================================
+ Hits        95688    95691       +3     
- Misses     181864   181874      +10
Impacted Files Coverage Δ
libr/anal/p/anal_arm_cs.c 73.13% <40%> (-0.32%) ⬇️
libr/bin/pdb/pdb_downloader.c 76.42% <0%> (-0.25%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0baadb4...e09b5dd. Read the comment docs.

@radare radare merged commit 1b36c24 into radare:master Sep 8, 2018

4 checks passed

codecov/patch 40% of diff hit (target 34.47%)
Details
codecov/project Absolute coverage decreased by -<.01% but relative coverage increased by +5.52% compared to 0baadb4
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@radare

This comment has been minimized.

Show comment
Hide comment
@radare

radare Sep 8, 2018

Owner

good work! sadly you had to leave soon :__

Owner

radare commented Sep 8, 2018

good work! sadly you had to leave soon :__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment