Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring #13955

Merged
merged 2 commits into from May 5, 2019

Conversation

Projects
None yet
4 participants
@Vane11ope
Copy link
Collaborator

commented May 4, 2019

...and fix a few potential bugs

@Vane11ope Vane11ope closed this May 4, 2019

@Vane11ope Vane11ope reopened this May 4, 2019

@Vane11ope

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

is Appveyor fucked up?

@XVilka

This comment has been minimized.

Copy link
Collaborator

commented May 5, 2019

@Vane11ope no, it seems that it timed out, due to the slow regression tests passing. I wonder what changed recently.

@Vane11ope Vane11ope closed this May 5, 2019

@Vane11ope Vane11ope reopened this May 5, 2019

@Vane11ope

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

i closed it and reopened it just now to try the test one more time

@codecov-io

This comment has been minimized.

Copy link

commented May 5, 2019

Codecov Report

Merging #13955 into master will increase coverage by 0.42%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #13955      +/-   ##
==========================================
+ Coverage   37.13%   37.55%   +0.42%     
==========================================
  Files         941      942       +1     
  Lines      302996   311028    +8032     
==========================================
+ Hits       112503   116821    +4318     
- Misses     190493   194207    +3714
Impacted Files Coverage Δ
libr/core/panels.c 0% <0%> (ø) ⬆️
libr/core/project.c 56.72% <0%> (-0.35%) ⬇️
libr/core/agraph.c 55.8% <0%> (ø)
libr/core/cmd_write.c 49.14% <0%> (+1.03%) ⬆️
libr/cons/dietline.c 13.24% <0%> (+1.89%) ⬆️
libr/core/cmd_debug.c 11.37% <0%> (+2.17%) ⬆️
libr/core/cmd_log.c 13.02% <0%> (+2.28%) ⬆️
libr/core/cmd_print.c 49.32% <0%> (+2.33%) ⬆️
libr/core/visual.c 15.36% <0%> (+2.68%) ⬆️
libr/core/cmd.c 50.25% <0%> (+2.99%) ⬆️
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88eb44f...48e0a26. Read the comment docs.

@Vane11ope

This comment has been minimized.

Copy link
Collaborator Author

commented May 5, 2019

it worked :D

@radare

This comment has been minimized.

Copy link
Owner

commented May 5, 2019

@radare radare merged commit 26b4bc3 into radare:master May 5, 2019

3 of 4 checks passed

codecov/patch 0% of diff hit (target 37.13%)
Details
codecov/project 37.55% (+0.42%) compared to 88eb44f
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Vane11ope Vane11ope deleted the Vane11ope:vane11ope/panels branch May 6, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.