Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a bug related to reset_settings #1349

Merged
merged 1 commit into from Mar 21, 2019

Conversation

Projects
None yet
2 participants
@Vane11ope
Copy link
Contributor

Vane11ope commented Mar 21, 2019

I found a bug when resetting settings.

Reproduce:

Open Graph Overview then reset settings, then you will see Graph Overview does not properly honor the settings.

Fix:

when reset settings, clear the settings first then reset layout, the order should be like this.

bug

bug2

@xarkes

xarkes approved these changes Mar 21, 2019

Copy link
Member

xarkes left a comment

Yep thanks :)

@xarkes xarkes merged commit 7fd815b into radareorg:master Mar 21, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.