Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DisassemblerGraphView zooming fix #1354

Merged
merged 3 commits into from Mar 23, 2019

Conversation

Projects
None yet
2 participants
@AntonReborn
Copy link
Contributor

AntonReborn commented Mar 22, 2019

What has been fixed:

Previously, during zooming using the wheel or +/-, the GraphView was zoomed to the top left corner. As well the scaling was linear, which break an experience, as almost all the modern editors use exponential zooming.

What has been changed:

  • In order to implement zooming to the cursor, the offset member of DisassemblerGraphView had to be adjusted correspondently. If using +/- the Graph zooms to the center of view;
  • current_scale now multiples by the exponent, instead of adding the constant.

Test plan:

  1. Open a graph with disassembler;
  2. Try to zoom.

graph_zoom

@ITAYC0HEN ITAYC0HEN merged commit e096f3e into radareorg:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.