Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build an app bundle on macOS #1355

Merged
merged 1 commit into from Mar 23, 2019

Conversation

Projects
None yet
3 participants
@Tatsh
Copy link
Contributor

Tatsh commented Mar 22, 2019

This change makes CMake output an app bundle on macOS (Cutter.app with proper setup). This was previously done by qmake.

Test plan (required)

Output executable Cutter should be located at ${CMAKE_CURRENT_BINARY_DIR}/Cutter.app/Contents/MacOS/Cutter. Double-clicking the bundle in Finder works as expected.

Closing issues

None.

@xarkes xarkes requested a review from thestr4ng3r Mar 23, 2019

@xarkes

xarkes approved these changes Mar 23, 2019

Copy link
Member

xarkes left a comment

Looks good to me.

@thestr4ng3r thestr4ng3r merged commit fa6e465 into radareorg:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@Tatsh Tatsh deleted the Tatsh:macos-bundle branch Mar 23, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.