Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/dialogs optimization #1360

Merged
merged 10 commits into from Mar 23, 2019

Conversation

Projects
None yet
4 participants
@ncyellow
Copy link
Contributor

ncyellow commented Mar 22, 2019

A lot of dialogs do not delete after close them. They delete only after teminate application. So its memory leak.

my patch fixes most of these problems.

Example leak;
https://github.com/radareorg/cutter/blob/master/src/menus/DisassemblyContextMenu.cpp#L452

function void DisassemblyContextMenu::on_actionEditInstruction_triggered()

create EditInstructionDialog every time.

@a1ext

This comment has been minimized.

Copy link
Member

a1ext commented Mar 22, 2019

Good catch!

@a1ext

a1ext approved these changes Mar 22, 2019

@xarkes

xarkes approved these changes Mar 23, 2019

Copy link
Member

xarkes left a comment

Nice one, thanks!

@xarkes xarkes merged commit f59dce1 into radareorg:master Mar 23, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.