Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add emu.str in Preferences->Metadata (#1276) #1369

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
3 participants
@RomeuG
Copy link
Contributor

RomeuG commented Mar 23, 2019

This PR solves #1276 .

Test plan (required)

emu.str on:

emu.str off:

Although there is an odd behavior that is also reproducible in the radare 2 CLI: if you check and then uncheck again, the result in the disassembly will be as if asm.emu was turned on, is that intended or am I missing something?

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 23, 2019

Although there is an odd behavior that is also reproducible in the radare 2 CLI: if you check and then uncheck again, the result in the disassembly will be as if asm.emu was turned on, is that intended or am I missing something?

I guess maybe emu.str can't work without asm.emu
@trufae do you know to answer this question? Is this an issue?

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 23, 2019

Thank you RomeuG! :)

@xarkes

xarkes approved these changes Mar 23, 2019

Copy link
Member

xarkes left a comment

Appart the mentionned bug, looks good to me.

@ITAYC0HEN ITAYC0HEN merged commit a2eb001 into radareorg:master Mar 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.