Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compiler information to dashboard (#1379) #1385

Merged
merged 1 commit into from Mar 24, 2019
Merged
Changes from all commits
Commits
File filter...
Filter file types
Jump to…
Jump to file or symbol
Failed to load files and symbols.
+25 −1
Diff settings

Always

Just for now

@@ -53,6 +53,7 @@ void Dashboard::updateContents()
this->ui->subsysEdit->setText(item2["subsys"].toString());
this->ui->endianEdit->setText(item2["endian"].toString());
this->ui->compiledEdit->setText(item2["compiled"].toString());
this->ui->compilerEdit->setText(item2["compiler"].toString());

This comment has been minimized.

Copy link
@xarkes

xarkes Mar 24, 2019

Member

This will overwrite what was written with the line just above.
If you believe the issue is just a key typo, then remove the line above.

This comment has been minimized.

Copy link
@xarkes

xarkes Mar 24, 2019

Member

You can also add a condition here as @ITAYC0HEN suggested, to check the value of item2["compiler"] and write N/A if empty.

this->ui->bitsEdit->setText(QString::number(item2["bits"].toDouble()));

if (!item2["relro"].isUndefined()) {
@@ -56,7 +56,7 @@
<x>0</x>
<y>0</y>
<width>1055</width>
<height>979</height>
<height>982</height>
</rect>
</property>
<layout class="QHBoxLayout" name="horizontalLayout_5">
@@ -839,6 +839,29 @@
</property>
</widget>
</item>
<item row="9" column="0">
<widget class="QLabel" name="label_5">
<property name="font">
<font>
<weight>75</weight>
<bold>true</bold>
</font>
</property>
<property name="text">
<string>Compiler:</string>
</property>
</widget>
</item>
<item row="9" column="1">
<widget class="QLineEdit" name="compilerEdit">
<property name="text">
<string>--</string>
</property>
<property name="frame">
<bool>false</bool>
</property>
</widget>
</item>
</layout>
</item>
</layout>
ProTip! Use n and p to navigate between commits in a pull request.
You can’t perform that action at this time.