Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve hexdump width calculation. #1389

Merged
merged 1 commit into from Mar 24, 2019

Conversation

Projects
None yet
2 participants
@karliss
Copy link
Contributor

karliss commented Mar 24, 2019

idealWidth seems to work better than "resonable size" chosen by adjustSize. It still doesn't work too well when zooming, but it didn't work before as well.

Test plan (required)
Tested with all sizes(4, 8, 16, 32) in hex and octal modes.
Before:
Before
After:
After

Closing issues
Closes #1351

@ITAYC0HEN ITAYC0HEN merged commit 8d6622a into radareorg:master Mar 24, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 24, 2019

Thank you very much! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.