Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xrefs select top item #1401

Merged
merged 4 commits into from Mar 27, 2019

Conversation

Projects
None yet
3 participants
@ncyellow
Copy link
Contributor

ncyellow commented Mar 26, 2019

Try to select first refs. If refs is empty try to select xrefs.

xrefs select

fixes #1363

ncyellow added some commits Mar 26, 2019

closes #1363
select top item from refs or xrefs

@pelijah pelijah requested a review from a1ext Mar 26, 2019

@xarkes
Copy link
Member

xarkes left a comment

Looks good to me, can you please update the coding style I mentioned? Thanks :)

Show resolved Hide resolved src/common/Helpers.cpp Outdated
Show resolved Hide resolved src/dialogs/XrefsDialog.cpp Outdated
@@ -72,6 +72,15 @@ QTreeWidgetItem *appendRow(QTreeWidget *tw, const QString &str, const QString &s
return tempItem;
}

This comment has been minimized.

Copy link
@ITAYC0HEN

ITAYC0HEN Mar 27, 2019

Member

Please document this function using our documentation formatting

This comment has been minimized.

Copy link
@ncyellow

ncyellow Mar 27, 2019

Author Contributor

done

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 27, 2019

Looks very good! Thank you :)
Just socument the function using our [documentation style] (https://cutter.re/docs/code.html#docstrings) and I'll merge

@xarkes

xarkes approved these changes Mar 27, 2019

@xarkes

This comment has been minimized.

Copy link
Member

xarkes commented Mar 27, 2019

Looks good to me, thanks!

@ITAYC0HEN ITAYC0HEN merged commit fbe9aea into radareorg:master Mar 27, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.