Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get color for optimization #1404

Merged
merged 4 commits into from Mar 30, 2019

Conversation

Projects
None yet
5 participants
@ncyellow
Copy link
Contributor

ncyellow commented Mar 28, 2019

small optimization getColorFor

  • remove unused parameter
  • replace local variable to static const variable

ncyellow added some commits Mar 26, 2019

@xarkes

xarkes approved these changes Mar 29, 2019

Copy link
Member

xarkes left a comment

Lgtm.

Show resolved Hide resolved src/dialogs/NewFileDialog.cpp Outdated
Show resolved Hide resolved src/dialogs/NewFileDialog.cpp Outdated

Solved

@ITAYC0HEN ITAYC0HEN merged commit d0540d7 into radareorg:master Mar 30, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 30, 2019

Very nice! Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.