Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take pixel ratio into account for graph cache. #1405

Merged
merged 2 commits into from Apr 3, 2019

Conversation

Projects
None yet
4 participants
@karliss
Copy link
Contributor

karliss commented Mar 28, 2019

Take pixel ratio into account when dealing with graphview cache. Changes based on this example.

Needs a bit more work as there are some graphic artifacts on the right and bottom edges, probably caused by bad floating point usage in size calculations.

Test plan (required)

  • Tested on Linux(gnome 2.32) by forcing mixed high dpi mode using export QT_SCREEN_SCALE_FACTORS="1;2" because Qt currently doesn't take into account gnome desktop scaling settings. There is an issue in QT bugtracker for that.
  • Would be good to test on windows 10, if I remember correctly QT respected windows desktop scaling settings
  • Would be good to test on macOS (don't have access to it)

Closing issues
Closes #1395

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Mar 30, 2019

@a1ext maybe you can test on Linux and macOS?

karliss added some commits Mar 28, 2019

Small high dpi improvments
* unpainted lines at bottom and right of GraphView
* NewFileDialog icons
* some builtin icons

@karliss karliss force-pushed the karliss:graph-high-dpi branch from 5cf6318 to 9677913 Mar 30, 2019

@karliss karliss marked this pull request as ready for review Mar 30, 2019

@karliss

This comment has been minimized.

Copy link
Contributor Author

karliss commented Mar 30, 2019

What are the current requirements for minimum QT version support? Some of the high dpi stuff was added in 5.6.

@xarkes

This comment has been minimized.

Copy link
Member

xarkes commented Mar 31, 2019

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Apr 2, 2019

Yo @scrapbird! :) can you check if this PR does the trick and solve your issue?

@scrapbird

This comment has been minimized.

Copy link

scrapbird commented Apr 2, 2019

@ITAYC0HEN will do when I'm home later tonight :) cheers man

@scrapbird scrapbird referenced this pull request Apr 3, 2019

Closed

Graph view is blurry #1395

@ITAYC0HEN ITAYC0HEN merged commit 103dece into radareorg:master Apr 3, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Apr 3, 2019

Thank you, very nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.