Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analysis maximum basic block fix #1424

Merged
merged 1 commit into from Apr 14, 2019

Conversation

Projects
None yet
2 participants
@xarkes
Copy link
Member

xarkes commented Apr 4, 2019

The option was changed to anal.bb.maxsize, but the format also changed
from integer to 'size' e.g. 512K. This fixes the inputs and uses the
value from r2 (512K).

@ITAYC0HEN
Copy link
Member

ITAYC0HEN left a comment

Seems like the user wont have any indication when they set wrong input. While before it was an integer, it was enough to limit the textbox to integer input. Now the possible input is more complicated with "K" and stuff..

@xarkes

This comment has been minimized.

Copy link
Member Author

xarkes commented Apr 5, 2019

I will delete the option.

@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Apr 12, 2019

Ping @xarkes. It's been a week :)

@xarkes

This comment has been minimized.

Copy link
Member Author

xarkes commented Apr 12, 2019

Life goes fast!

@xarkes xarkes force-pushed the xarkes:maxbb branch from 12ab620 to 4a4e562 Apr 12, 2019

@ITAYC0HEN ITAYC0HEN merged commit 5b0ef4c into radareorg:master Apr 14, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.