Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Python stable ABI >= 3.5 #1426

Merged
merged 2 commits into from Apr 8, 2019

Conversation

Projects
None yet
3 participants
@pelijah
Copy link
Contributor

pelijah commented Apr 4, 2019

The main idea of this changes is to make Cutter independent from Python3 subversion (at least on Windows).
https://docs.python.org/3/c-api/stable.html

@pelijah pelijah marked this pull request as ready for review Apr 5, 2019

@pelijah pelijah force-pushed the pelijah:python_stable_abi branch from e255e8d to 1479ff4 Apr 5, 2019

@pelijah pelijah force-pushed the pelijah:python_stable_abi branch from 1479ff4 to a2844cc Apr 6, 2019

@pelijah pelijah requested a review from radareorg/cutter-maintainers Apr 6, 2019

@pelijah

This comment has been minimized.

Copy link
Contributor Author

pelijah commented Apr 6, 2019

Cutter from Appveyor + python3.7 =
изображение

UPD:
Now Cutter requires only python3.dll and you can use any Python3 version >= 3.5.

@xarkes
Copy link
Member

xarkes left a comment

Looks good to me, I will try it on linux later.

@pelijah pelijah requested a review from thestr4ng3r Apr 8, 2019

@thestr4ng3r
Copy link
Member

thestr4ng3r left a comment

No problems on Linux

@thestr4ng3r thestr4ng3r merged commit 3d454cd into radareorg:master Apr 8, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.