Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make graph layout more failure resistant. #1427

Merged
merged 1 commit into from Apr 5, 2019

Conversation

Projects
None yet
3 participants
@karliss
Copy link
Contributor

karliss commented Apr 5, 2019

Prevents assert from triggering or code crashing when there unreachable blocks in graph view.

Test plan (required)

  • Compile cutter in debug mode
  • Find a function that looks like #1419 example, observe that assert triggers
  • Apply this PR and observe that graph view works

Better fix that prevents that actually processes unreachable blocks and their edges will be part of #1419, I am still working on it.
I am still making this PR because gradual degradation in edge cases is better than cutter not being usable at all.

Closing issues

@xarkes

xarkes approved these changes Apr 5, 2019

@ITAYC0HEN ITAYC0HEN merged commit df65f25 into radareorg:master Apr 5, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Apr 5, 2019

Thank you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.