Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus on visible disasm or graph #1444

Merged
merged 7 commits into from Apr 12, 2019

Conversation

Projects
None yet
3 participants
@optizone
Copy link
Contributor

optizone commented Apr 9, 2019

Now as @xarkes mentioned "start emulation" button has focus on start of Cutter.
I changed it so first visible disasm or graph widget has focus or if there are no visible disasm or graph - "start emulation" button has.

Closing issues
closes #1284

optizone added some commits Apr 9, 2019

Show resolved Hide resolved src/core/MainWindow.cpp
Show resolved Hide resolved src/core/MainWindow.cpp
Show resolved Hide resolved src/core/MainWindow.cpp Outdated

optizone added some commits Apr 10, 2019

@xarkes

xarkes approved these changes Apr 10, 2019

Copy link
Member

xarkes left a comment

I didn't test, but it looks much better!

// widgets are invisible but extra ones are visible

// Graph with function in it has focus priority over DisasmWidget
// if there are bot graph and disasm.

This comment has been minimized.

Copy link
@ITAYC0HEN
@ITAYC0HEN

This comment has been minimized.

Copy link
Member

ITAYC0HEN commented Apr 11, 2019

Looks good and works. Didn't check all the edge cases but looks good. Fix the typo and I will merge

@ITAYC0HEN ITAYC0HEN merged commit c6866df into radareorg:master Apr 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@optizone optizone deleted the optizone:bugfix branch Apr 12, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.