Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash in StringsWidget::on_actionX_refs_triggered. #1450

Merged
merged 1 commit into from Apr 12, 2019

Conversation

Projects
None yet
2 participants
@jbroadus
Copy link
Contributor

jbroadus commented Apr 11, 2019

Qt::WA_DeleteOnClose is set for a dialog that is allocated on the stack. This
causes Qt to attempt to delete the object when the XrefsDialog calls its close
method.

This appears to be a regression introduced in f59dce1. That changed the allocation of this object from heap to stack memory, but this flag was overlooked.

Test plan (required)

Repro case:

  • Right click on a referenced string in the strings list.
  • Choose Xrefs.
  • Double click on a referenced item.
  • Crash occurs.
Fix crash in StringsWidget::on_actionX_refs_triggered.
Qt::WA_DeleteOnClose is set for a dialog that is allocated on the stack. This
causes Qt to attempt to delete the object when the XrefsDialog calls its close
method.
@ITAYC0HEN
Copy link
Member

ITAYC0HEN left a comment

Thanks!!

@ITAYC0HEN ITAYC0HEN merged commit 2fee3da into radareorg:master Apr 12, 2019

2 checks passed

continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.