Join GitHub today
GitHub is home to over 36 million developers working together to host and review code, manage projects, and build software together.Sign up
Remove default Shiboken2 executable in qmake proj #1600
The correct executable path should be supplied on the command line when
When qmake is run with Python bindings enabled (
This is because the
It looks like the outer scope was added when updating to support cutter-deps on Windows. I think the intention was to skip the check on that platform because
In that case, I think it should work to remove the default value set earlier in the script, and rely on the later check which assigns a value to the variable with
Test plan (required)
I tested this locally with my Archlinux setup. The current Arch package's
According to my testing, prior to this change if Shiboken2 is not installed and available through
I am not currently in a position to test this build script change on Windows, MacOS, or any other Linux distro.
I also think that problems with this change wouldn't show up at all in AppVeyor because its build script specifies the value directly. They might in Travis, though.