New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes higher level API functions from r2pipe.rs #23

Merged
merged 3 commits into from Jul 15, 2017

Conversation

Projects
None yet
2 participants
@chinmaydd
Contributor

chinmaydd commented Jul 10, 2017

This is a API breaking change.

Bumps r2pipe to 0.5.0.

TODO:

  • Add README notice
  • Bump version
  • Creation of the radare2-r2pipe-api repository
  • Addition of r2api.rs crate code to above
  • Stable version of the crate on Cargo (Not needed, see here)
  • radeco-lib
  • rune (Updated in rsoc branch PR)

This functionality is to be moved to a newer repository. This is in-line with the discussion here. Multiple projects require wrappers around certain specific r2 features and pancake deemed it necessary to separate the core pipe-based logic and higher level constructs into a different project.

This PR will be updated with links to PRs to other r2-based dependent repositories.

@radare have a look. This should only be merged when all of the above projects have been stabilized to use the newer API.

This aims to make the following changes:
* Remove all higher-level structs
* Remove certain functions used to interact with the r2 instance and
retrieve specific information

This functionality aims to be moved to r2pipe.rs-frontend repository.
@radare

This comment has been minimized.

Show comment
Hide comment
@radare

radare Jul 11, 2017

Collaborator
Collaborator

radare commented Jul 11, 2017

@chinmaydd

This comment has been minimized.

Show comment
Hide comment
@chinmaydd

chinmaydd Jul 11, 2017

Contributor

I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder.

Contributor

chinmaydd commented Jul 11, 2017

I think either is fine. To keep up with the convention and abstain from creating additional repositories, I think adding it as folder under the name "rust" is just fine. Although, we might need to setup the test framework accordingly for each API folder.

@radare

This comment has been minimized.

Show comment
Hide comment
@radare

radare Jul 11, 2017

Collaborator
Collaborator

radare commented Jul 11, 2017

@chinmaydd

This comment has been minimized.

Show comment
Hide comment
@chinmaydd

chinmaydd Jul 15, 2017

Contributor

@radare, I think you can merge this PR and then have look over at radeco-lib and merge that as well.

Contributor

chinmaydd commented Jul 15, 2017

@radare, I think you can merge this PR and then have look over at radeco-lib and merge that as well.

@chinmaydd chinmaydd changed the title from [NOT FOR MERGE] Removes higher level API functions from r2pipe.rs to Removes higher level API functions from r2pipe.rs Jul 15, 2017

@radare radare merged commit 09622db into radareorg:master Jul 15, 2017

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details
@radare

This comment has been minimized.

Show comment
Hide comment
@radare

radare Jul 15, 2017

Collaborator
Collaborator

radare commented Jul 15, 2017

@chinmaydd chinmaydd deleted the chinmaydd:0.5.0 branch Jul 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment