Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix `afs` to use `td`/`tl` #13451

Closed
XVilka opened this issue Mar 21, 2019 · 6 comments
Closed

Fix `afs` to use `td`/`tl` #13451

XVilka opened this issue Mar 21, 2019 · 6 comments
Assignees
Milestone

Comments

@XVilka
Copy link
Member

@XVilka XVilka commented Mar 21, 2019

Currently afs is just a stub. To think how better to implement it - either make an alias for td or something else.

@radare

This comment has been minimized.

Copy link
Collaborator

@radare radare commented Mar 21, 2019

FTR:

  • afs right now seems to do nothing, neither shows or sets any function signature
  • you can redefine the function signature with td by redefining the functioni if we use the same name in the type
  • function types cant contain dots. so iits not possible to define signatures for sym.fun.xxx functions
  • imho afs. should be an alias for tf. which doesnt exist either, but must display the func signature
  • td/tl doesnt works for function signatures, only structs afaik, thats confusing and not consistent.
  • to get the current function signature one must use afcf which is kind of confusing because its not related to calling conventions
@radare

This comment has been minimized.

Copy link
Collaborator

@radare radare commented Mar 21, 2019

  • td int main(int argc) # works to redefine main signature

Question: how to do type propagation after any function signature change? imnho we should send a message when this happens

@sivaramaaa

This comment has been minimized.

Copy link
Collaborator

@sivaramaaa sivaramaaa commented Mar 21, 2019

Question: how to do type propagation after any function signature change?

@radare you can use afta command for propagating type

imnho we should send a message when this happens

Yup this could be done , so that it's automatic !

@radare

This comment has been minimized.

Copy link
Collaborator

@radare radare commented Mar 21, 2019

@radare

This comment has been minimized.

Copy link
Collaborator

@radare radare commented Mar 29, 2019

ping? can you fix this @XVilka

@XVilka

This comment has been minimized.

Copy link
Member Author

@XVilka XVilka commented Mar 29, 2019

Yes, I will do it tonight.

XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
XVilka added a commit to XVilka/radare2 that referenced this issue Mar 30, 2019
@XVilka XVilka closed this in 726e150 Mar 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.