Move current z80 plugin to extras

[radare]

We have z80.cr plugin which is LGPL instead of NC-GPL, and its cleaner.

[jvoisin]

What about removing the current z80 plugin instead? Its code is awful suboptimal, its license is non LGPL, and comments are in German.

Also, the other one is working, we don't need two disassemblers.

[radare]

Why remove if it works and can be moved to extras? There are tons of tests written for it.. We should put some tests for extras at some point.

Im aware of the gpl thing and the code quality. But i dont like to see code die if its ok.

On 16 Sep 2015, at 00:46, jvoisin notifications@github.com wrote:

What about removing the current z80 plugin instead? Its code is awful suboptimal, its license is non LGPL, and comments are in German.

—
Reply to this email directly or view it on GitHub.

[radare]

@condret are u ok with this?

[jvoisin]

I think that he said ok to remove the current (and awful) z80 one on IRC

[radare]

Ok. Will purge today

On 25 Sep 2015, at 01:53, jvoisin notifications@github.com wrote:

I think that he said ok to remove the current (and awful) z80 one on IRC

—
Reply to this email directly or view it on GitHub.

[Maijin]

Related z80-cr issues:

#2119
#2075

[radare]

Regressions should be updated too

[Maijin]

Regressions are already z80 and not z80-cr

[radare]

Z80 is the plug that must be killed. So all those tests will presumabily fail

On 29 Sep 2015, at 19:29, Maijin notifications@github.com wrote:

Regressions are already z80 and not z80-cr

—
Reply to this email directly or view it on GitHub.

[Maijin]

Ok

[Maijin]

I remember @condret said he will generate the test for z80.cr just like he did for z80

[radare]

ok, so let’s wait for condret to do this

On 29 Sep 2015, at 21:46, Maijin notifications@github.com wrote:

I remember @condret https://github.com/condret said he will generate the test for z80.cr just like he did for z80

—
Reply to this email directly or view it on GitHub #3287 (comment).

[radare]

move it to 1.0, we should do a major plugin re-organization after the release. to make the core smaller and handier

[Maijin]

@radare r2pm for the win :D

[radare]

@condret can you post some tests for the z80.cr transition? so we can safely move the old plugin to extras?

[crowell]

This issue was moved to radareorg/radare2-pm#3